GetAllocs uses a blocking query #2177
Merged
+151
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes GetAllocs use a blocking query as well as adding a sanity check to the clients watchAllocation code to ensure it gets the correct allocations. This PR fixes #2119 and #2153. The issue was that the client was talking to two different servers, one to check which allocations to pull and the other to pull those allocations. However the latter call was not with a blocking query and thus the client would not retreive the allocations it requested. The logging has been improved to make the problem more clear as well.
diptanu
suggested changes
Jan 11, 2017
| // We didn't get everything we wanted. Do not update the | ||
| // MinQueryIndex, sleep and then retry. | ||
| select { | ||
| case <-time.After(2 * time.Second): |
There was a problem hiding this comment.
Can we add a jitter here to prevent thundering hards across the cluster?
This was referenced Jan 11, 2017
jippi
reviewed
Jan 12, 2017
| if len(pull) != 0 { | ||
| // Pull the allocations that need to be updated. | ||
| allocsReq.AllocIDs = pull | ||
| allocsReq.MinQueryIndex = resp.Index - 1 |
There was a problem hiding this comment.
The allocations I want are already at that index and MinQueryIndex waits for the index to be greater than the passed index.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes GetAllocs use a blocking query as well as adding a sanity
check to the clients watchAllocation code to ensure it gets the correct
allocations.
This PR fixes #2119, fixes #2153 and fixes #2133.
The issue was that the client was talking to two different servers, one
to check which allocations to pull and the other to pull those
allocations. However the latter call was not with a blocking query and
thus the client would not retreive the allocations it requested.
The logging has been improved to make the problem more clear as well.